Skip to content

feat: apply ui example integration#347

Open
null-crafter wants to merge 3 commits into
mainfrom
feat/apply-ui-example-integration
Open

feat: apply ui example integration#347
null-crafter wants to merge 3 commits into
mainfrom
feat/apply-ui-example-integration

Conversation

@null-crafter

@null-crafter null-crafter commented Jul 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Checklist

  • Tests were added/updated according to the feature/bugfix/change made
  • Version was rolled according to semver requirements
  • API endpoints openapi schema was updated if applicable

Changes

Requires https://github.com/iblai/iblai-web-frontend/pull/1927

Please go to http://localhost:3000/apply to see the UI.

Screenshot_0000000000000211 Screenshot_0000000000000212

@null-crafter
null-crafter requested a review from mamigot as a code owner July 16, 2026 20:52
@mamigot

mamigot commented Jul 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Claude finished @null-crafter's task —— View job

E2E Coverage Bot

  • Dismiss stale REQUEST_CHANGES reviews
  • Identify changed files
  • Run mechanical coverage check — FAILED (new route uncovered)
  • Read current coverage state
  • Applied decision logic — CASE A: requested changes

Coverage check failed. The PR adds app/apply/page.tsx (a new route) but includes no e2e journey spec or updates to e2e/coverage.json / e2e/COVERAGE.md.

A REQUEST_CHANGES review has been posted explaining what's needed.

mamigot
mamigot previously requested changes Jul 16, 2026
View reviewed changes

@mamigot mamigot left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ E2E Coverage Required

This PR adds new routes but does not include e2e journey tests or coverage updates.

Missing coverage for:

  • app/apply/page.tsx — new Apply page route with no journey spec or coverage mapping

To fix:

  1. Add a journey spec in e2e/journeys/ testing the new apply page feature (e.g., e2e/journeys/NN-apply-page.spec.ts)
  2. In e2e/coverage.json: add the route to sourceFiles[] and add checkpoint entries with "status": "covered"
  3. In e2e/COVERAGE.md: add matching [x] checkpoint lines

Run locally to verify:

node e2e/scripts/check-journey-coverage.mjs --all

@mamigot

mamigot commented Jul 21, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Claude finished @null-crafter's task —— View job

Claude finished @null-crafter's task —— View job

E2E Coverage Bot

  • Dismiss stale REQUEST_CHANGES reviews
  • Identify changed files
  • Run mechanical coverage check — FAILED (new route uncovered)
  • Read current coverage state
  • Applied decision logic — CASE A: requested changes

Coverage check failed. The PR adds app/apply/page.tsx (a new route) but includes no e2e journey spec or updates to e2e/coverage.json / e2e/COVERAGE.md.

A REQUEST_CHANGES review has been posted explaining what's needed.

@mamigot
mamigot dismissed their stale review July 21, 2026 16:15

Re-evaluating after new commits.

mamigot
mamigot previously requested changes Jul 21, 2026
View reviewed changes

@mamigot mamigot left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ E2E Coverage Required

This PR adds new routes but does not include e2e journey tests or coverage updates.

Missing coverage for:

  • app/apply/page.tsx — new Apply page route with no journey spec or coverage mapping

To fix:

  1. Add a journey spec in e2e/journeys/ testing the new apply page feature (e.g., e2e/journeys/62-apply-page.spec.ts)
  2. In e2e/coverage.json: add the route to sourceFiles[] and add checkpoint entries with "status": "covered"
  3. In e2e/COVERAGE.md: add matching [x] checkpoint lines

Run locally to verify:

node e2e/scripts/check-journey-coverage.mjs --all

@mamigot

mamigot commented Jul 21, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Claude finished @null-crafter's task —— View job

E2E Coverage Bot

  • Dismiss stale REQUEST_CHANGES reviews
  • Identify changed files
  • Run mechanical coverage check — FAILED (new route uncovered)
  • Read current coverage state
  • Applied decision logic — CASE A: requested changes

Coverage check failed. The PR adds app/apply/page.tsx (a new route) but includes no e2e journey spec or updates to e2e/coverage.json / e2e/COVERAGE.md.

A REQUEST_CHANGES review has been posted explaining what's needed.

@mamigot
mamigot dismissed their stale review July 21, 2026 16:54

Re-evaluating after new commits.

mamigot
mamigot requested changes Jul 21, 2026
View reviewed changes

@mamigot mamigot left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ E2E Coverage Required

This PR adds new routes but does not include e2e journey tests or coverage updates.

Missing coverage for:

  • app/apply/page.tsx — new Apply page route with no journey spec or coverage mapping

To fix:

  1. Add a journey spec in e2e/journeys/ testing the new apply page feature (e.g., e2e/journeys/62-apply-page.spec.ts)
  2. In e2e/coverage.json: add the route to sourceFiles[] and add checkpoint entries with "status": "covered"
  3. In e2e/COVERAGE.md: add matching [x] checkpoint lines

Run locally to verify:

node e2e/scripts/check-journey-coverage.mjs --all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mamigot mamigot mamigot requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@null-crafter @mamigot